Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait parameter to jobs #99

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add wait parameter to jobs #99

merged 2 commits into from
Jan 23, 2023

Conversation

helmuthfilho
Copy link
Contributor

This PR adds wait as a paremeter to run method on Gush::Workflow.

@helmuthfilho helmuthfilho changed the title Add wait parameter to running jobs Add wait parameter to jobs Jan 20, 2023
@pokonski
Copy link
Contributor

Thank you for this, it's a good option to have :)

Can I ask you to add a test case for it?

@helmuthfilho
Copy link
Contributor Author

Thank you for this, it's a good option to have :)

Can I ask you to add a test case for it?

Sure! i will look into it

@pokonski pokonski merged commit 1a056c7 into chaps-io:master Jan 23, 2023
@pokonski
Copy link
Contributor

pokonski commented Jan 23, 2023 •
edited

Thank you for the contribution! 😁

@helmuthfilho helmuthfilho deleted the add_wait_param_to_job branch January 25, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@helmuthfilho @pokonski