Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around for flakey code coverage reporting #741

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

JohnAlbin
Copy link
Collaborator

This pull request is for: (mark with an "x")

  • packages/next-drupal

GitHub Issue: #740

Describe your changes

A change has been introduced into Node.js v18.20 and v20.10 and later that affects how Jest is able to use v8 for code coverage. Using an older version of node.js will allow the code coverage report to be reported correctly consistently.

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Apr 17, 2024 2:29pm

@JohnAlbin JohnAlbin mentioned this pull request Apr 17, 2024
@JohnAlbin
Copy link
Collaborator Author

JohnAlbin commented Apr 17, 2024

We are using pull_request_target in .github/workflows/next-drupal.yml because it would be BAD to allow anyone to alter the way the PR ran tests inside a PR; that's a vector for malicious code.

So this PR is using the next-drupal workflow from the main branch and the tests are failing in main right now due to this bug. I added another commit that adds a specific branch name to run the workflow and pushed it to #742 and it proves that this PR's change actually fixes the bug.

Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnAlbin JohnAlbin merged commit 2a9aa28 into main Apr 18, 2024
10 of 11 checks passed
@JohnAlbin JohnAlbin deleted the 740-fix-code-coverage branch April 18, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants