Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flattenDepth #1364

Closed
char0n opened this issue Mar 18, 2020 · 3 comments · Fixed by #1421
Closed

flattenDepth #1364

char0n opened this issue Mar 18, 2020 · 3 comments · Fixed by #1421
Labels
enhancement first-timers-only help wanted

Comments

@char0n
Copy link
Owner

char0n commented Mar 18, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
flattenDepth function contains reference to internal ramda function called _makeFlat which further makes reference to _isArrayLike. We have _isArrayLike function implemented in ramda-adjunct, so we only need to reimplement makeFlat into our codebase. Be aware that function just cannot be copied due to licensing reasons, it really needs to be understood and reimplemented.

Describe the solution you'd like
See text above..

Describe alternatives you've considered

--

Additional context

--
@char0n
Copy link
Owner Author

char0n commented Mar 18, 2020

@willblake01 this is possible candidate for you.

@willblake01
Copy link
Contributor

@char0n This one would be a good challenge. I'm looking over it but I don't see isArrayList. Just want to confirm, did you mean isArrayLike?

ryanbas21 added a commit to ryanbas21/ramda-adjunct that referenced this issue Apr 24, 2020
@ryanbas21
refactor(makeFlat): use internal makeFlat
f1e8766 
This addresses the issue char0n#1364 which asks to use an internal version of makeFlat for flattenDepth
rather than the ramda one.

This is essentially the ramda one with some changes for the linting and closes char0n#1364
ryanbas21 added a commit to ryanbas21/ramda-adjunct that referenced this issue Apr 24, 2020
@ryanbas21
refactor(makeFlat): use internal makeFlat
81d0c9d 
This addresses the issue char0n#1364 which asks to use an internal version of makeFlat for flattenDepth
rather than the ramda one.

This is essentially the ramda one with some changes for the linting and closes char0n#1364
@ryanbas21 ryanbas21 mentioned this issue Apr 24, 2020
Merged
@char0n
Copy link
Owner Author

char0n commented Apr 24, 2020 •
edited
Loading

@willblake01 sorry, it was isArrayLike. I've corrected the issue description.

char0n pushed a commit that referenced this issue May 15, 2020
@ryanbas21
refactor(flattenDepth): use internal makeFlat function (#1421)
26c226e 
Closes #1364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement first-timers-only help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(makeFlat): use internal makeFlat ryanbas21/ramda-adjunct
2 participants
@char0n @willblake01