only decode if filesystem encoding is defined #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I had an issue where pip would fail to install because on my QNX system
sys.getfilesystemencoding()
returnedNone
. This is conformant (see the documentation) and has been fixed in distlib already (see this issue).I originally reported it to pip, however it was suggested to fix it here directly.
Happy to hear any suggestions.
Cheers, André