Merge pull request #152 from BoatsAreRockable/eslint

Add ESLint for JavaScript linting
charlielee · Apr 29, 2016 · e3176ef · e3176ef
2 parents fcd766e + e819824
commit e3176ef
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 26 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,14 @@
+{
+  "env": {
+    "browser": true,
+    "node": true,
+    "es6": true
+  },
+  "rules": {
+    "no-undef": "error",
+    "no-unused-vars": ["error", {"varsIgnorePattern": "utils"}]
+  },
+  "globals": {
+    "utils": true
+  }
+}
diff --git a/app/animator.html b/app/animator.html
@@ -9,7 +9,7 @@
     <link rel="stylesheet" href="css/animator.css">
 </head>
 
-<body onload="startup()">
+<body>
     <!--Notification Bar-->
     <section id="notification-container">
         <div class="notification hidden">

diff --git a/app/js/about.js b/app/js/about.js
@@ -1,6 +1,3 @@
-/*jslint browser: true, node: true, debug: true*/
-/* global Buffer, process */
-
 // Launcher window
 var launcherVersion = document.querySelector("#app-version"),
     win = nw.Window.get();

diff --git a/app/js/index.js b/app/js/index.js
@@ -1,6 +1,3 @@
-/*jslint browser: true, node: true, debug: true*/
-/* global nw */
-
 (function() {
     "use strict";
     let win      = nw.Window.get(),

diff --git a/app/js/main.js b/app/js/main.js
@@ -1,6 +1,3 @@
-/*jslint browser: true, node: true, debug: true*/
-/* global Buffer, process, utils */
-
 // The width and height of the captured photo. We will set the
 // width to the value defined here, but the height will be
 // calculated based on the aspect ratio of the input stream.
@@ -63,7 +60,6 @@ var width  = 640,
     frameExportDirectory  = _getSaveDirectory(),
     exportedFramesList    = [],
     curDirDisplay         = document.querySelector("#currentDirectoryName"),
-    changeDirectoryButton = document.querySelector("#changeDirectoryButton"),
 
     // Onion skin
     isOnionSkinEnabled = false,
@@ -181,6 +177,7 @@ function startup() {
         },
         function(err) {
             console.error("Could not find a camera to use!");
+            console.error(err);
             notifyError("Could not find a camera to use!");
         }
     );
@@ -303,6 +300,7 @@ function startup() {
         }
     });
 }
+window.onload = startup;
 
 /**
  * Toggle between playback and capture windows.

diff --git a/app/js/newsfeed.js b/app/js/newsfeed.js
@@ -1,5 +1,4 @@
-  /* global nw */
-  module.exports = {};
+module.exports = {};
 
 (function() {
     "use strict";

diff --git a/app/js/utils.js b/app/js/utils.js
@@ -1,18 +1,18 @@
 const utils = (function() {
-    "use strict";
+  "use strict";
 
-    const win = nw.Window.get();
+  const win = nw.Window.get();
 
-    /**
-     * Open a URL in the user's browser.
-     *
-     * @param {String} url - The URL to open.
-     */
-    function openURL(url) {
-        nw.Shell.openExternal(url);
-    }
+  /**
+   * Open a URL in the user's browser.
+   *
+   * @param {String} url - The URL to open.
+   */
+  function openURL(url) {
+    nw.Shell.openExternal(url);
+  }
 
-    return {
-        openURL: openURL
-    };
+  return {
+    openURL: openURL
+  };
 }());