Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon not been added to executable when building Windows binaries #221

Closed
charlielee opened this issue Dec 21, 2018 · 3 comments
Closed

Icon not been added to executable when building Windows binaries #221

charlielee opened this issue Dec 21, 2018 · 3 comments
Labels
bug Things that are broken
Milestone
v0.10

Comments

@charlielee
Copy link
Owner

No description provided.

@charlielee charlielee added the bug Things that are broken label Dec 21, 2018
@charlielee charlielee modified the milestones: v0.8.x, v0.9.x Dec 22, 2018
@charlielee
Copy link
Owner Author

Moved to v0.9.x as I'll relook at build methods then

@charlielee
Copy link
Owner Author

charlielee commented Jan 8, 2019 •
edited
Loading

Looks like this is a bug with nwjs-builder, not really sure why as no new version has been released, and nothing has changed at our end.

Anyway, it seems that nwjs-builder is no longer being maintained, so I shall move us back to nw-builder (I believe we used the tool pre NW.js 0.13!). The 2 libraries are pretty similar so not much work will be required.

Can confirm that nw-builder doesn't have this issue.

This was referenced Jul 31, 2019
Closed
Merged
@charlielee
Copy link
Owner Author

Fixed in #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that are broken
Projects
None yet
Milestone
v0.10
Development

No branches or pull requests
1 participant
@charlielee