New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `visit_format_spec` to avoid false positives for F541 in f-string format specifier #1528

Merged

charliermarsh merged 3 commits into astral-sh:main from harupy:add-visit_format_spec

Jan 1, 2023

Contributor

harupy commented Jan 1, 2023 •

edited

See #1514 for details.


          Add visit_format_spec

b1e8f21

harupy force-pushed the add-visit_format_spec branch from a3828f0 to b1e8f21 Compare

January 1, 2023 09:54


          Improve tests

df74fef

harupy commented

View reviewed changes

resources/test/fixtures/pyflakes/F821_0.py

Comment on lines +92 to +93

		C = f'{A:{B}}'
		C = f'{A:{f"{B}"}}'

Contributor Author

harupy Jan 1, 2023

Test cases to ensure we do visit child nodes in format_spec.

harupy commented

View reviewed changes

src/ast/visitor.rs

Comment on lines +41 to +43

+                  fn visit_format_spec(&mut self, format_spec: &'a Expr) {
+                      walk_expr(self, format_spec);
+                  }

Contributor Author

harupy Jan 1, 2023 •

edited

This is a special method to separate normal JoinedStr and format-spec JoinedStr.


          Fix comment

7bc35e9

Member

charliermarsh commented Jan 1, 2023

Nice work.

charliermarsh merged commit 509c6d5 into astral-sh:main

renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request


          ⬆️ Update dependency ruff to ^0.0.206 (#16)

12df02d

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.205` ->
`^0.0.206` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.206/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.206/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.206/compatibility-slim/0.0.205)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.206/confidence-slim/0.0.205)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.206`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.206)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.205...v0.0.206)

#### What's Changed

- PyUpgrade: Turn errors into OSError by
[@&#8203;colin99d](https://togithub.com/colin99d) in
[astral-sh/ruff#1434
- Add dark mode variant for benchmark image by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1519
- Ignore property assignments in RET504 by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1520
- Avoid some false positives for ends-in-period checks by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1521
- Pyupgrade: `import mock` to `from unittest import mock` by
[@&#8203;colin99d](https://togithub.com/colin99d) in
[astral-sh/ruff#1488
- Fix `Name` node range in `NamedExpr` node by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#1526
- Simplify unused snapshot check by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#1525
- Do not Change Quotation Style for `SIM118` Autofix by
[@&#8203;saadmk11](https://togithub.com/saadmk11) in
[astral-sh/ruff#1529
- Add `visit_format_spec` to avoid false positives for F541 in f-string
format specifier by [@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#1528
- Rewrite mock.mock attribute accesses by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1533

**Full Changelog**:
astral-sh/ruff@v0.0.205...v0.0.206

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment