bug: cannot suspend bubbletea process

[knz]

In unix shells it's expected that a terminal program suspends itself when the user pressses Ctrl+Z (which sends the signal SIGTSTP to the process).

However, bubbletea disables this terminal feature which results in Ctrl+Z becoming ineffective.

In bubbline, we're solving this by using this key handler.

However this is cumbersome, and should be handled inside bubbletea directly, perhaps controlled by a top level program option.

cc @muesli

[knz]

NB: if you're interested I could pull the functionality out of bubbline into a PR for bubbletea. Let me know.

[muesli]

Agreed, since we already have a default signal handler, we should probably strive to support SIGTSTP as well.

[knz]

since we already have a default signal handler, we should probably strive to support SIGSTP as well.

It's the other way around: the process does not handle SIGTSTP itself (the kernel does). However, Ctrl+Z should send SIGTSTP to the process.

I'll send a PR.

[muesli]

I'm aware of that, I just meant we are already providing "extra convenience" like a default signal handler, so it probably makes sense to complete the signal handling. On a slightly related note, I'm currently making the signal handler optional, and I'm wondering if the same option flag should also affect SIGTSTP / SIGQUIT handling then.

[knz]

SIGTSTP only works if the process does not catch it in its signal handler. So I think the existing signal handling is fine to support suspend properly.