Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table Example #360

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Add Table Example #360

merged 1 commit into from
Aug 18, 2022

Conversation

maaslalani
Copy link
Member

Adds example using table bubble.

LONCHHAIHONG
LONCHHAIHONG approved these changes Jul 11, 2022
View reviewed changes
Copy link

@LONCHHAIHONG LONCHHAIHONG left a comment •
edited by muesli
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleted spam]

@maaslalani maaslalani marked this pull request as ready for review July 21, 2022 19:12
@Bwahharharrr
Copy link
Contributor

Bwahharharrr commented Jul 31, 2022 •
edited
Loading

This seems to now not be in master ? I swear this was merged like a week ago..
https://github.com/charmbracelet/bubbletea/tree/master/examples

@muesli
Copy link
Member

muesli commented Jul 31, 2022

@Bwahharharrr The PR is still open and marked as ready for review. You're probably thinking of a different commit/PR.

@maaslalani
Copy link
Member Author

@Bwahharharrr You may be thinking of charmbracelet/bubbles#173

@maaslalani maaslalani merged commit 8b7b791 into master Aug 18, 2022
@maaslalani maaslalani deleted the table branch August 18, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LONCHHAIHONG LONCHHAIHONG LONCHHAIHONG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maaslalani @Bwahharharrr @muesli @LONCHHAIHONG