Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: visible cursor in altscreen (#190) #462

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: visible cursor in altscreen (#190) #462

wants to merge 2 commits into from

Conversation

muesli
Copy link
Member

@muesli muesli commented Sep 27, 2022

Recovered from #452 by @londek:

The reasoning behind this hideCursor is behavior of AltScreen in cmd.exe; cmd stores two different cursor "states" for both AltScreen and main buffer so, we have to explicitly call hideCursor whenever we enter AltScreen. This should also fix cursor bugs on other platforms

Closes #190.

@muesli muesli added the bug Something isn't working label Sep 27, 2022
@muesli muesli mentioned this pull request Sep 27, 2022
Closed
muesli added a commit that referenced this pull request Oct 13, 2022
@muesli
fix: maintain cursor visibility across altscreen state switch
cc9ee39 
Based on #462 and #452 by @londek, but fixes maintaining the
current visiblity state across altscreen state changes.

This makes the behavior consistent across terminals.

Fixes #190.
muesli added a commit that referenced this pull request Oct 13, 2022
@muesli
fix: maintain cursor visibility across altscreen state switch
ac13d58 
Based on #462 and #452 by @londek, but fixes maintaining the
current visibility state across altscreen state changes.

This makes the behavior consistent across terminals, some of which
keep separate state for altscreen and regular buffer.

Fixes #190.
@muesli muesli mentioned this pull request Oct 13, 2022
Merged
muesli added a commit that referenced this pull request Oct 23, 2022
@muesli
fix: maintain cursor visibility across altscreen state switch
0f1ce7f 
Based on #462 and #452 by @londek, but fixes maintaining the
current visibility state across altscreen state changes.

This makes the behavior consistent across terminals, some of which
keep separate state for altscreen and regular buffer.

Fixes #190.
@meowgorithm
Copy link
Member

Is this one still relevant @muesli? If so, would be happy to get it in.

@muesli
Copy link
Member Author

muesli commented Mar 13, 2023

Yep, still relevant. I'll rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor visible in cmd.exe on Windows when the altscreen is active
3 participants
@muesli @meowgorithm @londek