Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make input options mutually exclusive #734

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

meowgorithm
Copy link
Member

Just some internal housekeeping: basically WithCustomInput and WithInputTTY can not longer both exist in startupOptions internally. When both are passed as ProgramOptions the last one wins.

@meowgorithm meowgorithm requested a review from muesli May 5, 2023 19:24
Copy link
Member

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meowgorithm
Copy link
Member Author

Thanks @muesli!

@meowgorithm meowgorithm merged commit fcc805f into master May 5, 2023
@meowgorithm meowgorithm deleted the input-tidying branch May 5, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants