chore: various linter-related improvements and overrides #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
approved these changes
Jul 7, 2023
caarlos0
approved these changes
Jul 7, 2023
no problem, your changes are actually better than mine (and I also had forgotten about that PR hehe) |
muesli
reviewed
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various linter-suggested improvements, and some overrides.
Also, apologies @caarlos0: I completely overlooked #724 back in April. Because input parsing has changed so much since then I figure it's easier at this point to simply supersede your earlier PR (but let me know if you feel differently).
Supersedes #724.