feat: use (exported) consts for default styles #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
reviewed
May 18, 2023
maaslalani
approved these changes
May 18, 2023
muesli
approved these changes
May 19, 2023
There was a problem hiding this comment.
That seems so reasonable, I'm wondering why I didn't do that in the first place. Thanks @meowgorithm!
hogo6002
pushed a commit
to google/osv-scanner
that referenced
this pull request
Mar 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [deps.dev/api/v3](https://togithub.com/google/deps.dev) | require | digest | `81f5387` -> `ff53416` | | | | | | [github.com/charmbracelet/glamour](https://togithub.com/charmbracelet/glamour) | require | minor | `v0.6.0` -> `v0.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/jedib0t/go-pretty/v6](https://togithub.com/jedib0t/go-pretty) | require | patch | `v6.5.5` -> `v6.5.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/owenrumney/go-sarif/v2](https://togithub.com/owenrumney/go-sarif) | require | patch | `v2.3.0` -> `v2.3.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/exp | require | digest | `c7f7c64` -> `a685a6e` | | | | | --- ### Release Notes <details> <summary>charmbracelet/glamour (github.com/charmbracelet/glamour)</summary> ### [`v0.7.0`](https://togithub.com/charmbracelet/glamour/releases/tag/v0.7.0) [Compare Source](https://togithub.com/charmbracelet/glamour/compare/v0.6.0...v0.7.0) #### Fixed - Render URLs in table by [@​brianstrauch](https://togithub.com/brianstrauch) in [charmbracelet/glamour#248 - Align GitHub flavoured Tables by [@​maaslalani](https://togithub.com/maaslalani) in [charmbracelet/glamour#284 #### Changes - feat: use (exported) consts for default styles by [@​meowgorithm](https://togithub.com/meowgorithm) in [charmbracelet/glamour#232 - Bump github.com/alecthomas/chroma/v2 from 2.7.0 to 2.8.0 by [@​dependabot](https://togithub.com/dependabot) in [charmbracelet/glamour#243 #### New Contributors - [@​garymh](https://togithub.com/garymh) made their first contribution in [charmbracelet/glamour#222 - [@​Benicas](https://togithub.com/Benicas) made their first contribution in [charmbracelet/glamour#251 - [@​brianstrauch](https://togithub.com/brianstrauch) made their first contribution in [charmbracelet/glamour#248 **Full Changelog**: charmbracelet/glamour@v0.6.0...v0.7.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>jedib0t/go-pretty (github.com/jedib0t/go-pretty/v6)</summary> ### [`v6.5.6`](https://togithub.com/jedib0t/go-pretty/releases/tag/v6.5.6) [Compare Source](https://togithub.com/jedib0t/go-pretty/compare/v6.5.5...v6.5.6) #### What's Changed - text: remove unused regular expression by [@​jedib0t](https://togithub.com/jedib0t) in [jedib0t/go-pretty#308 - Allow alphanumerical sort to be case-insensitive by [@​Skeeve](https://togithub.com/Skeeve) in [jedib0t/go-pretty#309 - table: note about auto-merge and HTML/Markdown modes by [@​jedib0t](https://togithub.com/jedib0t) in [jedib0t/go-pretty#311 **Full Changelog**: jedib0t/go-pretty@v6.5.5...v6.5.6 </details> <details> <summary>owenrumney/go-sarif (github.com/owenrumney/go-sarif/v2)</summary> ### [`v2.3.1`](https://togithub.com/owenrumney/go-sarif/releases/tag/v2.3.1) [Compare Source](https://togithub.com/owenrumney/go-sarif/compare/v2.3.0...v2.3.1) #### What's Changed - Bump github.com/zclconf/go-cty from 1.14.0 to 1.14.1 by [@​dependabot](https://togithub.com/dependabot) in [owenrumney/go-sarif#72 - remove ioutil, use testing.TempDir by [@​arukiidou](https://togithub.com/arukiidou) in [owenrumney/go-sarif#73 - Bump github.com/zclconf/go-cty from 1.14.1 to 1.14.2 by [@​dependabot](https://togithub.com/dependabot) in [owenrumney/go-sarif#74 - Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 by [@​dependabot](https://togithub.com/dependabot) in [owenrumney/go-sarif#76 - Bump github.com/zclconf/go-cty from 1.14.2 to 1.14.3 by [@​dependabot](https://togithub.com/dependabot) in [owenrumney/go-sarif#75 - Bump github.com/zclconf/go-cty from 1.14.3 to 1.14.4 by [@​dependabot](https://togithub.com/dependabot) in [owenrumney/go-sarif#77 #### New Contributors - [@​arukiidou](https://togithub.com/arukiidou) made their first contribution in [owenrumney/go-sarif#73 **Full Changelog**: owenrumney/go-sarif@v2.3.0...v2.3.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
jaredallard
pushed a commit
to rgst-io/stencil
that referenced
this pull request
Mar 29, 2024
](https://renovatebot.com){kind=link}
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/glamour](https://togithub.com/charmbracelet/glamour) | `v0.6.0` -> `v0.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/glamour (github.com/charmbracelet/glamour)</summary> ### [`v0.7.0`](https://togithub.com/charmbracelet/glamour/releases/tag/v0.7.0) [Compare Source](https://togithub.com/charmbracelet/glamour/compare/v0.6.0...v0.7.0) #### Fixed - Render URLs in table by [@​brianstrauch](https://togithub.com/brianstrauch) in [charmbracelet/glamour#248 - Align GitHub flavoured Tables by [@​maaslalani](https://togithub.com/maaslalani) in [charmbracelet/glamour#284 #### Changes - feat: use (exported) consts for default styles by [@​meowgorithm](https://togithub.com/meowgorithm) in [charmbracelet/glamour#232 - Bump github.com/alecthomas/chroma/v2 from 2.7.0 to 2.8.0 by [@​dependabot](https://togithub.com/dependabot) in [charmbracelet/glamour#243 #### New Contributors - [@​garymh](https://togithub.com/garymh) made their first contribution in [charmbracelet/glamour#222 - [@​Benicas](https://togithub.com/Benicas) made their first contribution in [charmbracelet/glamour#251 - [@​brianstrauch](https://togithub.com/brianstrauch) made their first contribution in [charmbracelet/glamour#248 **Full Changelog**: charmbracelet/glamour@v0.6.0...v0.7.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rgst-io/stencil). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building an application with Glamour rendering, the linter suggested adding constants when
"auto"appeared in several places in the codebase. To that end, this PR introduces string constants that can be used to reference the default styles.AsciiStyleAutoStyleDarkStyleDraculaStyleLightStyleNoTTYStylePinkStyleNote that this revision uses the constants internally as well, however I have left the examples in the README as-is for sake of simplicity.