feat: add alt + shift modifiers #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @elmarsan, this PR looks great. 1 suggestion is can we change the syntax (in the docs) from: to: |
maaslalani
reviewed
Jun 9, 2023
Co-authored-by: Maas Lalani <maas@lalani.dev>
* feat: setting to control cursor blinking * feat: create bool type * feat: parser updated * readme wording Co-authored-by: Maas Lalani <maas@lalani.dev> * Update README.md Co-authored-by: Maas Lalani <maas@lalani.dev> * Update parser.go * Update token.go * Update parser.go * Apply suggestions from code review --------- Co-authored-by: Maas Lalani <maas@lalani.dev>
…bracelet#321) Bumps [github.com/go-rod/rod](https://github.com/go-rod/rod) from 0.112.8 to 0.113.3. - [Release notes](https://github.com/go-rod/rod/releases) - [Commits](go-rod/rod@v0.112.8...v0.113.3) --- updated-dependencies: - dependency-name: github.com/go-rod/rod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…armbracelet#310) Bumps [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty) from 0.0.18 to 0.0.19. - [Commits](mattn/go-isatty@v0.0.18...v0.0.19) --- updated-dependencies: - dependency-name: github.com/mattn/go-isatty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Added note to the comment that is generated when a user calls `vhs new` to call out that `TypingSpeed` can be customized globally, and defaults to 50ms
|
@maaslalani it should be ready 😀 |
|
Awesome @elmarsan, going to get this one in today for sure after testing it out. |
|
Amazing work @elmarsan! This is fantastic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add support for
AltandShiftmodifiers.Closes #33