feat: setting to control cursor blinking #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tr3mor
commented
Jun 9, 2023
|
Thank you so much! This looks perfect! |
tr3mor
commented
Jun 9, 2023
lexer_test.go
Outdated
Comment on lines
39
to
41
| {SET, "Set"}, | ||
| {CURSOR_BLINK, "CursorBlink"}, | ||
| {STRING, "false"}, |
There was a problem hiding this comment.
I think making it as STRING and parsing as bool later is fine, but if you think we need another type for bool (I believe this is the first one) let me know
There was a problem hiding this comment.
Having a boolean type would be great for long term if possible.
There was a problem hiding this comment.
The bool type would also make parser errors much nicer.
We can leverage the parser errors stuff we already have:
Set CursorBlink fals
^^^^ expected boolean value
There was a problem hiding this comment.
Done, also updated parser to check for valid values
There was a problem hiding this comment.
Sweet, this looks fantastic!
maaslalani
approved these changes
Jun 9, 2023
Co-authored-by: Maas Lalani <maas@lalani.dev>
Co-authored-by: Maas Lalani <maas@lalani.dev>
maaslalani
reviewed
Jun 9, 2023
maaslalani
reviewed
Jun 9, 2023
maaslalani
reviewed
Jun 9, 2023
|
Looking great! We can merge after the suggested changes are in. |
maaslalani
reviewed
Jun 9, 2023
elmarsan
pushed a commit
to elmarsan/vhs
that referenced
this pull request
Jun 14, 2023
* feat: setting to control cursor blinking * feat: create bool type * feat: parser updated * readme wording Co-authored-by: Maas Lalani <maas@lalani.dev> * Update README.md Co-authored-by: Maas Lalani <maas@lalani.dev> * Update parser.go * Update token.go * Update parser.go * Apply suggestions from code review --------- Co-authored-by: Maas Lalani <maas@lalani.dev>
maaslalani
added a commit
that referenced
this pull request
Jun 14, 2023
* feat: add alt + shift modifiers * style: fix lint issues * Update parser.go Co-authored-by: Maas Lalani <maas@lalani.dev> * Theme test: fix ineffectual assignment * test: add more test cases for suggestions * feat: setting to control cursor blinking (#324) * feat: setting to control cursor blinking * feat: create bool type * feat: parser updated * readme wording Co-authored-by: Maas Lalani <maas@lalani.dev> * Update README.md Co-authored-by: Maas Lalani <maas@lalani.dev> * Update parser.go * Update token.go * Update parser.go * Apply suggestions from code review --------- Co-authored-by: Maas Lalani <maas@lalani.dev> * docs: Set CursorBlink examples * docs: fix CursorBlink example sizing * feat(deps): bump github.com/go-rod/rod from 0.112.8 to 0.113.3 (#321) Bumps [github.com/go-rod/rod](https://github.com/go-rod/rod) from 0.112.8 to 0.113.3. - [Release notes](https://github.com/go-rod/rod/releases) - [Commits](go-rod/rod@v0.112.8...v0.113.3) --- updated-dependencies: - dependency-name: github.com/go-rod/rod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(deps): bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19 (#310) Bumps [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty) from 0.0.18 to 0.0.19. - [Commits](mattn/go-isatty@v0.0.18...v0.0.19) --- updated-dependencies: - dependency-name: github.com/mattn/go-isatty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add note on TypingSpeed for new users in `demo.tape` (#327) Added note to the comment that is generated when a user calls `vhs new` to call out that `TypingSpeed` can be customized globally, and defaults to 50ms * docs: modify Ctrl keyword syntax * docs: update readme --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Maas Lalani <maas@lalani.dev> Co-authored-by: Andreas Deininger <andreas@deininger.net> Co-authored-by: bashbunni <bunni@bashbunni.dev> Co-authored-by: Pavel Storozhenko <storozhenkopf@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Johnston <m@ttjohnston.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting
CursorBlinkto disable cursor blinking. Current behavior kept as default one.Closes #319
Blinking disabled:
Default behavior: