Command err handling #480
Merged
Command err handling #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified function signatures to return errors - Added error checks after command executions - Added specific error messages for different failures - Updated the handling of parser errors for source tape parsing - Altered evaluator to incorporate the revised error handling
- Moved the logic for waiting until the "window.term" variable is accessible from VHS setup to evaluation phase - This ensures the proper timing and handling of errors related to the 'term' variable access (some SET commands access term)
|
This is fantastic @mastercactapus, thank you for this awesome work! |
|
@maaslalani pushed a fix for the lint issue that came up |
|
Tested this out and it worked great. This is a great improvement to VHS, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates command functions to return errors when unable to continue.
termif it hadn't started yet.Dependency of #257 to address the concern of stopping/bubbling up if an error occurs without resorting to panic #257 (comment)