lock k8s-keystone-auth to a k8s version tag instead of "latest" #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but normally we would merge into master first and then backport to release-1.19. We need this in master to make sure it doesn't get unpinned in 1.20. |
My thought was that |
|
We need to protect ourselves from ending up on :latest again. This needs to go in master so that if we get to the 1.20 release and forget to update this, then we stay on the :v1.19.0 tag rather than reverting to :latest. |
kwmonroe
changed the title
|
🥧 |
johnsca
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugs.launchpad.net/cdk-addons/+bug/1895190
We want to lock
k8s-keystone-authto the current release tag from upstream.