Adding support for loadbalancer-ips #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config option for specifying the load balancer IP to pass to the worker nodes. Allows for floating a virtual IP in front of the load balancers.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config option for specifying the load balancer IP to pass to the worker nodes. Allows for floating a virtual IP in front of the load balancers.
This is the load balancer side of charmed-kubernetes/charm-kubernetes-control-plane#5
The user would set this config on the master if not using a load balancer and on the load balancer if using one. At first, I thought this was redundant on the load balancer charm, but then I thought about the high availability use case and just wanting to have multiple load balancers and float a virtual IP in front of them through some other means.