Adding support for setting the virtual IP that points to the control plane #5
Conversation
Not quite. This affects kubeconfig files generated on kubernetes-master, but not on kubernetes-worker. The kubernetes-worker charm creates its own kubeconfigs using addresses it receives over the kube-api-endpoint relation, which might be related directly to kubernetes-master, but is usually related to kubeapi-load-balancer instead. |
Added a config change hook to kick off changes instead of waiting for the next hook run Fixed a minor flake8 issue Added a check for empty data, which can occur if the relation is going away
|
A good point, sir. I've updated the PR to include updating the relation data. I was on the fence about doing something like this for the kube-api-loadbalancer charm, but it is possible to have a virtual IP floating on the load balancers outside of juju and wanting to use that. As a result, I am going to add a similar PR to the load balancer charm. This will only work if there isn't a load balancer. I updated the config.yaml to spell that out. @evilnick I would love your input on the wording on the config.yaml section if you have any. |
hyperbolic2346
force-pushed
the
mwilson/custom-vip
branch
from
1f0220e
to
ea61f1b
Compare
hyperbolic2346
force-pushed
the
mwilson/custom-vip
branch
from
ea61f1b
to
cb97fa0
Compare
Note that all units will send all the IPs, but the interface will cull duplicates.
Pulling a fix for a condition in favor of a bug and fix just for that. Pulling config changed handler since we don't need it as cynerva pointed out in review
|
LGTM |
|
Feel free to merge this. I left it unmerged in case you wanted to wait for feedback on the config description. |
|
@hyperbolic2346 We should add something about this to the High Availability section of the docs (https://www.ubuntu.com/kubernetes/docs/high-availability) |
This allows for someone with an external load balancer to specify the IP that the workers will use to talk to the control plane.