Fix pause/resume actions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [lp:1824428](https://bugs.launchpad.net/charm-kubernetes-worker/+bug/1824428) 1. Rewrite actions to python so we can used get_host_name() from kubernetes_common. Using get_host_name() fixes the issue reported in the bug by returning the fqdn if a cloud integrator is being used. 2. Remove the `kubectl cordon` call from the pause action as it's redundant - `kubectl drain` *does* a cordon first. 3. Add --ignore-daemonsets as a default arg to `kubectl drain`. DS pods can't be drained as they would be immediately rescheduled by the DS controller, which ignores 'unschedulable' taints on the node. 4. Update action descriptions to more closely match upstream docs.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
lp:1824428
kubernetes_common. Using get_host_name() fixes the issue reported
in the bug by returning the fqdn if a cloud integrator is being used.
kubectl cordoncall from the pause action as it'sredundant -
kubectl draindoes a cordon first.kubectl drain. DS podscan't be drained as they would be immediately rescheduled by the DS
controller, which ignores 'unschedulable' taints on the node.