Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors based on discussion on Discourse #2

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

johnsca
Copy link
Contributor

@johnsca johnsca commented Nov 10, 2020

@johnsca
Copy link
Contributor Author

johnsca commented Nov 10, 2020

One change in this that's not relevant to the discussion on Discourse is that I started to find the k8s_service_available event name a bit off, so this is proposing to change it to k8s_services_changed. While that doesn't reflect the idea of the list first becoming populated, it's still true then that the list has "changed" (from being empty, previously) and the actual use-case for the event is to ensure that changes to the list do lead to updates to the pod spec, so I think it's more accurate. Open to discussion there, though. And, of course, this will require updating the charm code as well.

Also, I think it would be worth adding unit tests to this using the framework's testing harness.

Copy link
Contributor

@DomFleischmann DomFleischmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the changes and I they LGTM. This also solves our issue with emitting the k8s_services_changed event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants