Skip to content

Commit

Permalink
STY: core: move non-Py3 specific stuff out from npy_3kcompat.h to pri…
Browse files Browse the repository at this point in the history
…vate npy_pycompat.h

npy_3kcompat.h is semi-private, so this can be done.
  • Loading branch information
pv authored and charris committed Jul 13, 2012
1 parent ce0a791 commit 423ddfb
Show file tree
Hide file tree
Showing 50 changed files with 76 additions and 67 deletions.
19 changes: 0 additions & 19 deletions numpy/core/include/numpy/npy_3kcompat.h
Expand Up @@ -137,25 +137,6 @@ PyUnicode_Concat2(PyObject **left, PyObject *right)
*left = newobj;
}


/*
* Accessing items of ob_base
*/

#if (PY_VERSION_HEX < 0x02060000)
#define Py_TYPE(o) (((PyObject*)(o))->ob_type)
#define Py_REFCNT(o) (((PyObject*)(o))->ob_refcnt)
#define Py_SIZE(o) (((PyVarObject*)(o))->ob_size)
#endif

/*
* PyIndex_Check
*/
#if (PY_VERSION_HEX < 0x02050000)
#undef PyIndex_Check
#define PyIndex_Check(o) 0
#endif

/*
* PyFile_* compatibility
*/
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/dummymodule.c
Expand Up @@ -9,7 +9,7 @@
#define NPY_NO_DEPRECATED_API NPY_API_VERSION

#include <Python.h>
#include <numpy/npy_3kcompat.h>
#include <npy_pycompat.h>

static struct PyMethodDef methods[] = {
{NULL, NULL, 0, NULL}
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/array_assign.c
Expand Up @@ -16,7 +16,7 @@
#include <numpy/ndarraytypes.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "shape.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/array_assign_array.c
Expand Up @@ -15,7 +15,7 @@
#include <numpy/ndarraytypes.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "convert_datatype.h"
#include "methods.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/array_assign_scalar.c
Expand Up @@ -15,7 +15,7 @@
#include <numpy/ndarraytypes.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "convert_datatype.h"
#include "methods.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/arrayobject.c
Expand Up @@ -32,7 +32,7 @@ maintainer email: oliphant.travis@ieee.org

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/arraytypes.c.src
Expand Up @@ -7,7 +7,7 @@
#define _MULTIARRAYMODULE
#include "numpy/arrayobject.h"
#include "numpy/arrayscalars.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"
#include "numpy/npy_math.h"
#include "numpy/halffloat.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/buffer.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "buffer.h"
#include "numpyos.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/calculation.c
Expand Up @@ -8,7 +8,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "number.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/common.c
Expand Up @@ -6,7 +6,7 @@
#include "numpy/arrayobject.h"

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "usertypes.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/conversion_utils.c
Expand Up @@ -9,7 +9,7 @@
#include "numpy/arrayobject.h"

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "arraytypes.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/convert.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "arrayobject.h"
#include "mapping.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/convert_datatype.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "scalartypes.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/ctors.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "ctors.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/datetime.c
Expand Up @@ -18,7 +18,7 @@
#include <numpy/arrayobject.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "numpy/arrayscalars.h"
#include "methods.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/datetime_busday.c
Expand Up @@ -15,7 +15,7 @@
#include <numpy/arrayobject.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "numpy/arrayscalars.h"
#include "lowlevel_strided_loops.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/datetime_busdaycal.c
Expand Up @@ -16,7 +16,7 @@
#include <numpy/arrayobject.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "numpy/arrayscalars.h"
#include "lowlevel_strided_loops.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/datetime_strings.c
Expand Up @@ -17,7 +17,7 @@
#include <numpy/arrayobject.h>

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "numpy/arrayscalars.h"
#include "methods.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/descriptor.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "_datetime.h"
#include "common.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/dtype_transfer.c
Expand Up @@ -19,7 +19,7 @@
#include <numpy/arrayobject.h>
#include <numpy/npy_cpu.h>

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "convert_datatype.h"
#include "_datetime.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/einsum.c.src
Expand Up @@ -16,7 +16,7 @@
#define _MULTIARRAYMODULE
#include <numpy/arrayobject.h>
#include <numpy/halffloat.h>
#include <numpy/npy_3kcompat.h>
#include <npy_pycompat.h>

#include <ctype.h>

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/flagsobject.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/getset.c
Expand Up @@ -10,7 +10,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "scalartypes.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/hashdescr.c
Expand Up @@ -6,7 +6,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "hashdescr.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/item_selection.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "arrayobject.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/iterators.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "arrayobject.h"
#include "iterators.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/mapping.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "iterators.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/methods.c
Expand Up @@ -10,7 +10,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "ctors.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/multiarray_tests.c.src
Expand Up @@ -2,7 +2,7 @@
#include <Python.h>
#include "numpy/arrayobject.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

/*
* TODO:
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/multiarraymodule.c
Expand Up @@ -27,7 +27,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

NPY_NO_EXPORT int NPY_NUMUSERTYPES = 0;

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/nditer_impl.h
Expand Up @@ -17,7 +17,7 @@
#define NPY_NO_DEPRECATED_API NPY_API_VERSION
#define _MULTIARRAYMODULE
#include <numpy/arrayobject.h>
#include <numpy/npy_3kcompat.h>
#include <npy_pycompat.h>
#include "convert_datatype.h"

#include "lowlevel_strided_loops.h"
Expand Down
4 changes: 2 additions & 2 deletions numpy/core/src/multiarray/nditer_pywrap.c
Expand Up @@ -13,11 +13,11 @@
#define NPY_NO_DEPRECATED_API NPY_API_VERSION
#define _MULTIARRAYMODULE
#include <numpy/arrayobject.h>
#include <numpy/npy_3kcompat.h>
#include <npy_pycompat.h>

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

typedef struct NewNpyArrayIterObject_tag NewNpyArrayIterObject;

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/number.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "number.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/numpymemoryview.c
Expand Up @@ -16,7 +16,7 @@
#include "numpy/arrayscalars.h"

#include "npy_config.h"
#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "numpymemoryview.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/numpyos.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

/*
* From the C99 standard, section 7.19.6: The exponent always contains at least
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/refcount.c
Expand Up @@ -14,7 +14,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

static void
_fillobject(char *optr, PyObject *obj, PyArray_Descr *dtype);
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/scalarapi.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "ctors.h"
#include "descriptor.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/scalartypes.c.src
Expand Up @@ -13,7 +13,7 @@
#include "numpy/halffloat.h"
#include "numpy/arrayscalars.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "npy_config.h"
#include "mapping.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/sequence.c
Expand Up @@ -9,7 +9,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "common.h"
#include "mapping.h"
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/shape.c
Expand Up @@ -11,7 +11,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "ctors.h"

Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/ucsnarrow.c
Expand Up @@ -12,7 +12,7 @@

#include "npy_config.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

/*
* Functions only needed on narrow builds of Python for converting back and
Expand Down
2 changes: 1 addition & 1 deletion numpy/core/src/multiarray/usertypes.c
Expand Up @@ -34,7 +34,7 @@ maintainer email: oliphant.travis@ieee.org

#include "common.h"

#include "numpy/npy_3kcompat.h"
#include "npy_pycompat.h"

#include "usertypes.h"

Expand Down

0 comments on commit 423ddfb

Please sign in to comment.