Skip to content

Commit

Permalink
Set bound on black dep, return lint veto powers
Browse files Browse the repository at this point in the history
the most recent version of black made some changes, _and_ introduced some bugs: psf/black#1629

let's prevent an update until it's ready
  • Loading branch information
bdewilde committed Aug 26, 2020
1 parent 8527f91 commit 207fd42
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint_and_format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
python -m pip install black flake8
- name: check formatting with black
run: |
python -m black --diff src scripts
python -m black --diff --check src scripts
- name: lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ where = src
viz =
matplotlib>=1.5.0
dev =
black>=19.0b0
black>=19.0b0,<20.8b0
flake8>=3.8.0
m2r>=0.2.0
mypy>=0.600
Expand Down

1 comment on commit 207fd42

@bdewilde
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfw you leave a snarky commit message because you're running into strange behavior, forgetting that the github issue you've link to will show that message 🤦

much <3 to black -- as a sign of respect, i reworded this commit and force-pushed it to overwrite, but this orphan commit still shows up on the issue page. please ignore, and good luck with the upcoming official release!

Please sign in to comment.