Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design the field selection with custom x & y value selection #57

Merged
merged 39 commits into from
Oct 21, 2020
Merged

Re-design the field selection with custom x & y value selection #57

merged 39 commits into from
Oct 21, 2020

Conversation

razvanilin
Copy link
Member

@razvanilin razvanilin commented Oct 6, 2020 •
edited

Description

This is a big change I wanted to deal for a long time. Currently, the field selection is clunky and probably makes sense to only a few people. The new design and functionality will be updated so that users can map any value on the x & y axes and also be able to add custom filters.

  • Custom X & Y field selection ( also discussed here Support custom values #50)
  • Field operations such as count, sum, average
  • Custom filters that uses the entire dataset fetched from the data source
  • New UI for the field selection - away from the request modal as that doesn't make sense currently
  • Remove the need for selecting chart subTypes and update the UI functionality based on the X & Y automatically
  • Simple and improved chart type selector

Work-in-progress screens

image

@razvanilin
🚧 separated dataset colors into its own component
171cf09
@razvanilin
🚧 implemented first draft of the new data selection component
dda7ddf 
Changed personalisation to appearance in the wording
@razvanilin
🚧 small ui improvements to the new data component
8407325
@razvanilin
Merge branch 'master' into beta13
8eb4f05
@razvanilin
🚧 added basic UI functionality to the filters
e58fb3d
@razvanilin
🚧 keep all datasets as separate objects in the page
d612428
@razvanilin
🚧 updated the dataset model with the conditions field
b40dcca 
also removed the axis type field that was not used
@razvanilin
🚧 connected the new data selector to the back-end
54713dd
@razvanilin
🚧 fixed some console react warnings
9ee2443
@razvanilin
🚧 created a module to fetch all the fields available for selection
967afc3
@razvanilin
➕ added morgan to log express requests in development
dba225c
@razvanilin
💄 improved the visuals of the dataset section header
0ff62c6
@razvanilin
🚧 first draft of the new AxisChart class
765a79b
@razvanilin
🚧 added the sum and average operations to the axis class
7daa0a2
@razvanilin
🚧 first draft of the new bar chart class for constructing chart confi…
314ffde 
…guration
@razvanilin
🚧 added basic support for non-date x axis data
e6f317e
@razvanilin
🚧 added simple toggles for the chart types
7e4d708
@razvanilin
🚧 added the Line and Pie charts in the new chart system
075fdf4
@razvanilin
🚧 added multifill as an option in the dataset
165786a 
replaced chart subType need from the colors
@razvanilin razvanilin added the enhancement New feature label Oct 6, 2020
@razvanilin razvanilin self-assigned this Oct 6, 2020
@razvanilin razvanilin mentioned this pull request Oct 6, 2020
Closed
@razvanilin razvanilin added this to In progress in Chartbrew Devlog Oct 6, 2020
@razvanilin
💄 arranged the chart color section into two columns
d893521
@razvanilin
🚧 added the data type detection for the conditions
8b93907 
first implementation of date conditions
@razvanilin
💄 improved the calendar input with the app colors and GB format
0ad3742
@razvanilin
🗃️ added a new migration to add dateField to dataset
a0f8c15
@razvanilin
🚧 added dateField functionality setter in the UI and updated the UI a…
6069566 
… bit
@razvanilin
🚧 multiple bug fixes and edge cases checks
dfa6910
@razvanilin
🐛 fixed bug with date mutation when zeros are included in timeseries
0120742
@razvanilin
🚧 fixed date mutability when the includeZeros was true
7eb4a4d
@razvanilin
🚧 added support for multiple datasets with the new algorithm
26a7007
@razvanilin
🚧 fixed issue with multiple datasets on line charts
d22d0e1 
fixed issue with sorting dates with multiple datasets
@razvanilin
🔥 removed legacy code from the front-end
c66eb4a
@razvanilin
🔥 removed old code for the charts configuration in the backend
cfc5da3
@razvanilin razvanilin marked this pull request as ready for review October 21, 2020 13:48
@razvanilin razvanilin merged commit e07ef4f into master Oct 21, 2020
@razvanilin razvanilin mentioned this pull request Oct 27, 2020
Merged
@razvanilin razvanilin moved this from In progress to Done in Chartbrew Devlog Oct 27, 2020
@razvanilin razvanilin deleted the beta13 branch March 1, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@razvanilin razvanilin

Labels
enhancement New feature
Projects
Chartbrew Devlog
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@razvanilin