Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SavedQueries component into functional component #66

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Refactor SavedQueries component into functional component #66

merged 2 commits into from
Oct 22, 2020

Conversation

ashish979
Copy link
Contributor

@ashish979 ashish979 commented Oct 14, 2020 •
edited

for #58

razvanilin
razvanilin requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@razvanilin razvanilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor changes to the props deconstruction needed

Thanks for taking the time to send a PR 😀

client/src/components/SavedQueries.js Outdated Show resolved Hide resolved
razvanilin
razvanilin approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@razvanilin razvanilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@razvanilin razvanilin merged commit 80c7e19 into chartbrew:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanilin razvanilin razvanilin approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashish979 @razvanilin