refactor component LoginForm into functional component

[ameersami]

based on #58

[razvanilin]

Looks good!
Thanks for the PR, this component is a bit messy and the refactor definitely helps to simplify it in the future.

[ameersami]

@razvanilin thanks! I totally agree, if you want to make a separate issue for breaking this component up I could take a crack at it. I would recommend moving the OneaccountSVG, renderField, and the socialSignin into separate components to clean it up further.

[razvanilin]

@razvanilin thanks! I totally agree, if you want to make a separate issue for breaking this component up I could take a crack at it. I would recommend moving the OneaccountSVG, renderField, and the socialSignin into separate components to clean it up further.

I'm thinking at a complete re-write of the whole renderField stuff. It's done with redux-form which I'm not really a fan of. Better to have a custom and simple validation that validates everything when the login button is pressed.

I agree re the social signing. It will need to be in a separate component.

I'll have a look into this more after I finish with the beta13 feature changes

[razvanilin]

Just gave it a test and it's not working as intended. I believe there must be something going on with how the state is assigned and how redux-form handles the input.

The behaviour is the following:

• Click on the email field and start typing
• The field gets deselected after the first letter
• If focused again, it works to type the whole thing in
• Pressing Tab to move down to the password field does not work as intended (requires 2-3 presses for it to happen)
• Password field acts the same way as the email

Have you tested the changes you made locally and worked for you?

[razvanilin]

Closing as this was already refactored