Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敤 refactor ManageUser component #71

Merged
merged 2 commits into from
Nov 11, 2020
Merged

馃敤 refactor ManageUser component #71

merged 2 commits into from
Nov 11, 2020

Conversation

ozgunbal
Copy link
Contributor

Related issue #58

razvanilin
razvanilin approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@razvanilin razvanilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ozgunbal
Copy link
Contributor Author

hi, @razvanilin . This year, Hacktoberfest wants to observe PR is eligible for 2 weeks after it's pushed when you don't labeled with hacktoberfest-accepted. You removed the repository's hacktoberfest label so this PR's didn't count right now. Can you help me on this.

@razvanilin
Copy link
Member

@ozgunbal sorry, I had no idea removing the label has any secondary effect. I added both labels now, let me know if that did it. I will also merge this tomorrow or Thursday.

@ozgunbal
Copy link
Contributor Author

I don't know what their rules are, but currently 2 PR of mine has tagged via ineligible repository. I'm posting you the rules, for double check: https://hacktoberfest.digitalocean.com/hacktoberfest-update

@razvanilin
Copy link
Member

razvanilin commented Nov 10, 2020 •
edited

I sent an email to the Hacktoberfest team. I'll let you know if they manage to re-validate the PRs on their side

EDIT: The hacktoberfest team came back to me and said they are aware of the issue and looking into it

@razvanilin razvanilin merged commit 7c9b20c into chartbrew:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanilin razvanilin razvanilin approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ozgunbal @razvanilin