Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[BUG] Violation warnings in verbose level chrome dev tools logging #4287
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
I'm happy to look at a PR for this |
This comment has been minimized.
This comment has been minimized.
|
+1 |
asimkt
pushed a commit
to asimkt/Chart.js
that referenced
this issue
Jun 9, 2017
[BUG] Violation warnings in verbose level chrome dev tools logging
Closed
This comment has been minimized.
This comment has been minimized.
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
When will this be released? It seems like quite a long time between that fix and the release.. |
This comment has been minimized.
This comment has been minimized.
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Very soon: #4706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Expect Chart.js to not cause logs in dev console
Current Behavior
touchstart and touchend event listeners log verbose level [Violation] messages (see below).
Possible Solution
addEventListener can now take a map
{"passive": "true"}see the MDN entrySteps to Reproduce (for bugs)
[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. Chart.bundle.min.js:14Context
It's helpful to have verbose logging turned on in development because chrome will warn you when javascript execution locks up the browser. Having Chart.js warnings comingled with application logs reduces signal to noise.
Environment