Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Violation warnings in verbose level chrome dev tools logging #4287

Closed
snoe opened this issue May 25, 2017 · 6 comments
Closed

[BUG] Violation warnings in verbose level chrome dev tools logging #4287

snoe opened this issue May 25, 2017 · 6 comments

Comments

@snoe
Copy link

@snoe snoe commented May 25, 2017

Expected Behavior

Expect Chart.js to not cause logs in dev console

Current Behavior

touchstart and touchend event listeners log verbose level [Violation] messages (see below).

Possible Solution

addEventListener can now take a map {"passive": "true"} see the MDN entry

Steps to Reproduce (for bugs)

  1. Go to the unedited codepen: https://codepen.io/pen?template=JXVYzq
  2. Open chrome dev tools console and set log level to verbose
  3. Refresh page
  4. See verbose log in console: [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. Chart.bundle.min.js:14

Context

It's helpful to have verbose logging turned on in development because chrome will warn you when javascript execution locks up the browser. Having Chart.js warnings comingled with application logs reduces signal to noise.

Environment

  • Chart.js version: tried in 2.0/2.5/2.6
  • Browser name and version: Chrome OSX Version 58.0.3029.110 (64-bit)
@etimberg

This comment has been minimized.

Copy link
Member

@etimberg etimberg commented May 25, 2017

I'm happy to look at a PR for this

@nealoke

This comment has been minimized.

Copy link

@nealoke nealoke commented May 29, 2017

+1

asimkt pushed a commit to asimkt/Chart.js that referenced this issue Jun 9, 2017
[BUG] Violation warnings in verbose level chrome dev tools logging
@etimberg etimberg added this to the Version 2.7 milestone Jun 9, 2017
@Viral-Inc

This comment has been minimized.

Copy link

@Viral-Inc Viral-Inc commented Jun 12, 2017

+1

@burka

This comment has been minimized.

Copy link

@burka burka commented Aug 31, 2017

When will this be released? It seems like quite a long time between that fix and the release..

@nealoke

This comment has been minimized.

Copy link

@nealoke nealoke commented Sep 1, 2017

+1

@simonbrunel

This comment has been minimized.

Copy link
Member

@simonbrunel simonbrunel commented Sep 1, 2017

Very soon: #4706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.