Closes issue #4287 #4356
Closed
Closes issue #4287 #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BUG] Violation warnings in verbose level chrome dev tools logging
etimberg
reviewed
Jun 9, 2017
| @@ -723,7 +723,7 @@ module.exports = function(Chart) { | |||
| }; | |||
| helpers.addEvent = function(node, eventType, method) { | |||
| if (node.addEventListener) { | |||
| node.addEventListener(eventType, method); | |||
| node.addEventListener(eventType, method, {passive: true}); | |||
There was a problem hiding this comment.
Will adding this parameter cause issues on browsers other than Chrome? We should confirm that this doesn't break IE11 compatibility.
There was a problem hiding this comment.
It's not supported in IE and Edge and therefore options support needs to be detected in order to call addEventListener with the correct arguments.
There was a problem hiding this comment.
Is there any browser detection function which is already in Chart.js code? Then we could use that. I have found Chart.platform but I don't think it can be used to detect IE and Edge. Any thoughts?
|
Closing since this got implemented in #4424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Violation warnings in verbose level chrome dev tools logging.
I hope this closes #4287
I'm not sure whether this is the way to solve this issue. From https://developers.google.com/web/updates/2016/06/passive-event-listeners it may need to be in
passivefor a better scrolling in touch devices. Please comment and I'll change accordingly.Note: This's my first PR to a public repo. 馃槃