-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browserify build system #2007
Browserify build system #2007
Conversation
😮 nice! Not sure what the test failures are, but this would be great. @davis you might be interested in this |
Possible usages are: src/Chart.js (umd) dist/Chart.js (ChartJS) dist/Chart.min.js (ChartJS minified) dist/Chart.bundle.js (ChartJS with Moment.js) dist/Chart.bundle.min.js (ChartJS with Moment.js minified)
Closes #1898 |
Closes #1873 |
Closes #1479 |
Looks like this branch addresses #1989 too. |
Might also address #1847 |
Only thing I'd suggest adding to this is some samples & docs. Maybe show a sample where we pull it in with requireJS. It would also be great to have something in the docs about using it with require / browserify / webpack since it's a fairly common question that we get. |
nice! |
@tannerlinsley doc updates look good. you can go ahead and merge any-time then close out the above issues 😄 |
Possible usages are:
src/Chart.js (umd)
dist/Chart.js (vanilla)
dist/Chart.min.js (vanilla minified)
dist/Chart.bundle.js (vanilla with Moment.js)
dist/Chart.bundle.min.js (vanilla with Moment.js minified)