Fixed last tick overlap for time scale

[ankane]

First off, thanks for all the great work on this library!

This is a fix for #2599. It hides the last label unless it's equally spaced.

[panzarino]

It seems that this PR has been open for a while, what do you think about it @etimberg @tannerlinsley @simonbrunel? To me this just seems like a less complete version of #2600

[etimberg]

Agreed

[panzarino]

Closing as #2600 seems to be a better implementation of the same solution

[ankane]

No worries, hopefully #2600 can be resolved soon.

I'm sure everyone is busy, but it'd be great if someone could take a look at #2748 as well. It fixes a bug labeled P0.

[ankane]

Any chance you'll revisit this? There hasn't been progress on #2600 for 2 months, and there are decent number of open issues around it. #3069 #2774 #2249

[markterrill]

Hi, I'd be happy to take anything that will fix it! #2600 seems dead.

Edit: Thanks @ankane your one liner hack (} else if (me.scaleSizeInUnits === 0) {) did the trick!

[andyb3]

Thanks for this fix @ankane, this issue still hasn't been resolved and your solution seems to work very nicely!

[KonnikPahoni]

Hey everyone,

Still experiencing the issue.

[benmccann]

No ticks should overlap each other. We're currently focused on 3.0, which has numerous bug fixes. If you can reproduce with 3.0.0-alpha please file a new bug with an interactive example to reproduce and we'll take a look

[KonnikPahoni]

Should they overlap in 2.9.3? This is the version I'm using.

[benmccann]

Overlapping labels always seems like a bad experience to me. So they "shouldn't", but that being said I personally don't have time to make fixes to 2.x anymore. I know that 3.x does have some fixes such as #6927 that have the potential to fix this issue though I'm not sure if it does or not without testing

[KonnikPahoni]

In my case they overlap when I set min/max. I simply removed boundary ticks. I am a beginner so I can hardly contribute to solving this. Hopefully this will be resolved in 3.x!