Make index mode only work with the horizontal distance to an element #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Oct 15, 2016
| @@ -62,7 +63,9 @@ module.exports = function(Chart) { | |||
| } | |||
|
|
|||
| var center = element.getCenterPoint(); | |||
| var distance = Math.round(helpers.distanceBetweenPoints(position, center)); | |||
| var distance = distanceMetric ? | |||
There was a problem hiding this comment.
I would move the distanceMetric decision outside the loop:
if (!distanceMetric) {
distanceMetric = helpers.distanceBetweenPoints;
}
parseVisibleItems(chart, function(element) {
// ...
var distance = distanceMetric(position, center);| var distance = Math.round(helpers.distanceBetweenPoints(position, center)); | ||
| var distance = distanceMetric ? | ||
| distanceMetric(position, center) : | ||
| Math.round(helpers.distanceBetweenPoints(position, center)); |
There was a problem hiding this comment.
Do we really need to round the value?
There was a problem hiding this comment.
Probably not, i will remove it
simonbrunel
approved these changes
Oct 15, 2016
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
…hartjs#3471) Make index mode only work with the horizontal distance to an element if intersect is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only applies when
intersect: falseis in the tooltip options. @simonbrunel noticed this behaviour. I added a test to ensure that the horizontal distance is what applies.One question ... what do we do for horizontal bar charts? In that case we want to use the y direction. @chartjs/maintainers thoughts on this?