add 10 to yLabelWidth on set, rather than on use #677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding on the line chart's y-axis labels can get crowded because when checking the x-axis label rotation (line 1506) it checks for
this.yLabelWidth + 8
rather thanthis.yLabelWidth + 10
.Ex:
Changing this check to
yLabelWidth + 10
fixes this issue. However, since theyLabelWidth
variable is either used to only check against itself (in thefit()
method, lines 1462 & 1468), or checking againstyLabelWidth + 10
(line 1487 * 2, line 1506), I moved the addition to the setting ofyLabelWidth
, rather than when checking the variable.Result:
The result is correctly padded y-axis labels.