Update docs for .resize() method #8151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See chartjs#7678 and chartjs#8149. (The `silent` parameter mentioned in the original 7678 no longer exists.) Add JSDoc. Fix some minor issues with grammar and coding style consistency.
|
Thank you very much @joshkel |
etimberg
approved these changes
Dec 10, 2020
kurkle
approved these changes
Dec 14, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7678 and #8149. (The
silentparameter mentioned in the original 7678 no longer exists.)Add JSDoc. (I'm not sure if the Chart.js project wants JSDoc added to methods like this or not; please let me know if you'd rather I remove this.)
Fix some minor issues with grammar and coding style consistency.