Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename helpers.clear to helpers.clearCanvas #8238

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Rename helpers.clear to helpers.clearCanvas #8238

merged 2 commits into from
Dec 28, 2020

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 27, 2020

  • Change the parameters to canvas and optional ctx (for performance).

This is needed if we start drawing to multiple canvases.

etimberg
etimberg previously approved these changes Dec 27, 2020
View reviewed changes
@kurkle kurkle merged commit 66c9254 into chartjs:master Dec 28, 2020
@kurkle kurkle deleted the clear branch December 30, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurkle @etimberg