Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable label on ellipse annotation #749

Merged
merged 19 commits into from
Sep 28, 2022
Merged

Enable label on ellipse annotation #749

merged 19 commits into from
Sep 28, 2022

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented May 24, 2022 •
edited

This PR is enabling the labeling of the ellipse annotation.

TODO

  • test cases
  • types
  • documentation
  • samples

@stockiNail stockiNail added this to the 2.0.0 milestone May 24, 2022
@stockiNail stockiNail marked this pull request as ready for review May 24, 2022 12:38
@stockiNail
Copy link
Collaborator Author

stockiNail commented May 24, 2022 •
edited

@kurkle I was thinking that maybe we could remove the bounding box to clip the label inside the box annotation, as did in this PR for ellipse. It would be a breaking change.

EDIT
PR #764 removed bounding box in version 2.0.0

@stockiNail stockiNail mentioned this pull request Jun 1, 2022
Merged
7 tasks
@stockiNail stockiNail modified the milestones: 2.0.0, 2.1.0 Jun 3, 2022
@stockiNail stockiNail mentioned this pull request Jun 8, 2022
Merged
@stockiNail stockiNail mentioned this pull request Jun 8, 2022
Closed
@stockiNail stockiNail marked this pull request as draft July 21, 2022 15:46
@stockiNail stockiNail marked this pull request as ready for review August 5, 2022 10:43
@stockiNail stockiNail merged commit f85f494 into chartjs:master Sep 28, 2022
@stockiNail stockiNail deleted the ellipseLabel branch September 28, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee Awaiting requested review from LeeLenaleee

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stockiNail @kurkle