Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label clipping to box annotation size #764

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

stockiNail
Copy link
Collaborator

This PR is remove label clipping to box annotation size.

@stockiNail stockiNail added this to the 2.0.0 milestone Jun 9, 2022
@stockiNail stockiNail mentioned this pull request Jun 9, 2022
@stockiNail stockiNail marked this pull request as ready for review July 21, 2022 15:45
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee after merging this one, do you think we will bump to version 2?

@LeeLenaleee
Copy link
Collaborator

No, I am currently looking into moving project to TS, so if you give me till next week wednesday to see if I can make some progress on it. If I dont have made any progess after that we can merge it, else I want to try and switch to TS first.

Made a quick start on it but need to check things out since types dont match up so its a bit of research work

@stockiNail
Copy link
Collaborator Author

No, I am currently looking into moving project to TS, so if you give me till next week wednesday to see if I can make some progress on it. If I dont have made any progess after that we can merge it, else I want to try and switch to TS first.

No hurry, so take your time.

@stockiNail
Copy link
Collaborator Author

I hope to be able to continue contributing in TS because I don't know much about it 😔

@stockiNail stockiNail merged commit eee842c into chartjs:master Jul 22, 2022
@stockiNail stockiNail deleted the removeClipToBoxLabel branch July 22, 2022 13:18
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee I was thinking if it is not better to have a frozen situation before going to TS, merging all pending PR.
This could avoid a double and complex work on those PR

@LeeLenaleee
Copy link
Collaborator

LeeLenaleee commented Jul 22, 2022

hmmm yeah I guess, well lets release V2 and make it something for later then, its a nice bit of research work with how everything exactly works so it will take some time to do it, would be better for next major version

@stockiNail
Copy link
Collaborator Author

@LeeLenaleee do you want I try creating bump PR?

@LeeLenaleee
Copy link
Collaborator

Yeah sure 👍🏻

@stockiNail stockiNail mentioned this pull request Aug 4, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants