Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract getting favorite into function #13

Closed
wants to merge 4 commits into from
Closed

Extract getting favorite into function #13

wants to merge 4 commits into from

Conversation

chaspy
Copy link
Owner

@chaspy chaspy commented Oct 20, 2018

No description provided.

@chaspy chaspy changed the title [WIP]Extract getting favorite into function Extract getting favorite into function Oct 20, 2018
@chaspy
Copy link
Owner Author

chaspy commented Oct 20, 2018 •
edited

hi @kamontia!
In order to call from vue.js, we need a separation between authentication and getting favorite.

/favorite will be called from vue.js and you can see your favorite if you logged in.
http://localhost:4567/favorite

Please check 🙏

@chaspy chaspy requested a review from kamontia October 20, 2018 07:43
@chaspy chaspy mentioned this pull request Oct 20, 2018
Merged
@chaspy
Copy link
Owner Author

chaspy commented Oct 20, 2018 •
edited

let me close this PR because #14 that include changes of this PR will merged

@chaspy chaspy closed this Oct 20, 2018
@ghost ghost deleted the improve-server-side branch October 20, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamontia kamontia Awaiting requested review from kamontia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@chaspy