Try Vue.js #14
Merged
Try Vue.js #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change the behavior from the outside
Because only property is changed
|
@kamontia please review and merge. |
kamontia
reviewed
Oct 20, 2018
app.rb
Outdated
| result = request.env['omniauth.auth'] | ||
| @twitter.access_token = result.credentials.token | ||
| @twitter.access_token_secret = result.credentials.secret | ||
| get '/favorite' do |
There was a problem hiding this comment.
I think that the pass should be renamed /api/v1.0/favorite because this URL is not used with view rendering.
app.rb
Outdated
| session[:uid] = env['omniauth.auth']['uid'] | ||
| session[:twitter_oauth] = env['omniauth.auth'][:credentials] | ||
|
|
||
| redirect to('/') |
There was a problem hiding this comment.
Since authentication has been completed at this point, i suppose that it should be redirected to /top.
|
@kamontia |
|
Hello @chaspy , Thank you for your effort. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge first #13