Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator #89

Merged
merged 1 commit into from Jul 21, 2018
Merged

Conversation

cmichi
Copy link
Contributor

@cmichi cmichi commented Jul 20, 2018

I looked into #72 and here's the thing: Most of the waiting time with a blank page is spent when initially loading the bundle.js, which contains react and the app. Since we would like to show the loading indicator during that time we can't reuse the MDSpinner component, since it is only available after React is loaded up.

As a compromise I suggest a minimal loading screen. I have intentionally left out any text, since the translations are also not yet available during the loading phase.

The <div id="loading-screen></div> is automatically overwritten once the app's render() method is invoked by react.

Is displayed during the time when the App is initially fetched.
@chatch chatch merged commit bacd923 into chatch:master Jul 21, 2018
@chatch
Copy link
Owner

chatch commented Jul 21, 2018

perfect. looks good.

hey btw. have you seen the current build challenge: https://www.stellar.org/lumens/build ? you can get rewarded for contributions.

@cmichi
Copy link
Contributor Author

cmichi commented Jul 21, 2018

Great, thanks for the pointer and your quick feedback :-)!

@cmichi cmichi deleted the add-loading-indicator branch July 21, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants