Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into #72 and here's the thing: Most of the waiting time with a blank page is spent when initially loading the
bundle.js
, which contains react and the app. Since we would like to show the loading indicator during that time we can't reuse theMDSpinner
component, since it is only available after React is loaded up.As a compromise I suggest a minimal loading screen. I have intentionally left out any text, since the translations are also not yet available during the loading phase.
The
<div id="loading-screen></div>
is automatically overwritten once the app'srender()
method is invoked by react.