Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: If the app is available in the background, update the online status #752

Conversation

zaronwald
Copy link
Contributor

@zaronwald zaronwald commented Nov 29, 2023

Pull Request Template

Description

Added background fetching so that availability is updated even when app is minimized

Fixes #503

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@@ -572,7 +572,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.chatwoot.app;
PRODUCT_BUNDLE_IDENTIFIER = com.zach.chatwoot.app;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this.

@@ -605,7 +605,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.chatwoot.app;
PRODUCT_BUNDLE_IDENTIFIER = com.zach.chatwoot.app;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this.

Copy link
Member

@muhsin-k muhsin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Let's keep the changes focused on the issue we are trying to solve. I see a lot of changes that are not related to the issue we are trying to solve.

@muhsin-k muhsin-k changed the title Feature 503 update availability in background feat: If the app is available in the background, update the online status Feb 19, 2024
@muhsin-k muhsin-k assigned zaronwald and unassigned muhsin-k Feb 19, 2024
@muhsin-k
Copy link
Member

muhsin-k commented Jun 3, 2024

Closing this since there hasn't been any activity on this for a while. Let's reopen if required.

@muhsin-k muhsin-k closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: If the app is available in the background, update the online status regularly.
2 participants