Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: "presence" checks in Channel::TwilioSms #5206

Merged
merged 2 commits into from Oct 7, 2022
Merged

Fix: "presence" checks in Channel::TwilioSms #5206

merged 2 commits into from Oct 7, 2022

Commits on Aug 4, 2022

  1. Fix "presence" checks in Channel::TwilioSms 

    `:phone_number.presence` is evaluated at class-definition time and evaluates to
`:phone_number`.

`:phone_number?` is a Rails-provided method that is the same as
`phone_number.present?`.
    @jordan-brough
    jordan-brough committed Aug 4, 2022
    Copy the full SHA
    69efdae View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge branch 'develop' into twilio-channel-presence

    @tejaswinichile
    tejaswinichile committed Oct 6, 2022
    Copy the full SHA
    57d685d View commit details
    Browse the repository at this point in the history