Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: "presence" checks in Channel::TwilioSms #5206

Merged
merged 2 commits into from Oct 7, 2022
Merged

Fix: "presence" checks in Channel::TwilioSms #5206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69efdae
Fix "presence" checks in Channel::TwilioSms
jordan-brough Aug 4, 2022
57d685d
Merge branch 'develop' into twilio-channel-presence
tejaswinichile Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/channel/twilio_sms.rb
View file
Open in desktop
Expand Up @@ -28,8 +28,8 @@ class Channel::TwilioSms < ApplicationRecord
validates :auth_token, presence: true

# Must have _one_ of messaging_service_sid _or_ phone_number, and messaging_service_sid is preferred
validates :messaging_service_sid, uniqueness: true, presence: true, unless: :phone_number.presence
validates :phone_number, absence: true, if: :messaging_service_sid.presence
validates :messaging_service_sid, uniqueness: true, presence: true, unless: :phone_number?
validates :phone_number, absence: true, if: :messaging_service_sid?
validates :phone_number, uniqueness: true, allow_nil: true

enum medium: { sms: 0, whatsapp: 1 }
Expand Down