Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update heroku app.json to use premium plans #5349

Merged
merged 7 commits into from Dec 5, 2022

Conversation

vishnu-narayanan
Copy link
Member

@vishnu-narayanan vishnu-narayanan commented Aug 29, 2022

Pull Request Template

Description

Use premium/paid dynos and addons as Heroku is deprecated free dynos/addons.

Web and worker dynos will switch from free hobby dynos to basic dynos, which will be 7$/month. Postgres and Redis will switch from hobby-dev to mini plans, which will be 0.01$/month.

Fixes #5284

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Deployed on Heroku using this branch

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Use premium/paid dynos and addons as Heroku is set to deprecate free dynos/addons.
@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Aug 29, 2022
@vishnu-narayanan
Copy link
Member Author

deployment failed with premium plans as well
image

@vishnu-narayanan
Copy link
Member Author

deployment still failing after setting default stack to heroku-20

image

@vishnu-narayanan
Copy link
Member Author

vishnu-narayanan commented Aug 29, 2022

@sojan-official We could choose to have this change merged now or wait till Heroku deprecates the free plans. Deployment is successful with the free dynos via #5338

cc: @pranavrajs

@pr-triage pr-triage bot added PR: draft The pull request is not ready to be reviewed and removed PR: unreviewed This pull request is yet to be reviewed. labels Aug 29, 2022
@vishnu-narayanan vishnu-narayanan added the on-hold Issue is currently on hold label Sep 5, 2022
@vishnu-narayanan vishnu-narayanan self-assigned this Nov 2, 2022
@vishnu-narayanan vishnu-narayanan added ready-for-pickup post-planning The issues which are taken into the sprint after the planning session labels Nov 29, 2022
@netlify
Copy link

netlify bot commented Nov 29, 2022

Deploy Preview for chatwoot-storybook canceled.

Name Link
🔨 Latest commit c48ba9d
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/638e121839924a00080346b4

web and worker to use basic dynos
redis and postgres to use mini
@vishnu-narayanan
Copy link
Member Author

When should I update my app.json file to use the new dyno and data plans?
Eco Dynos
If you want to switch from using free to Eco dynos, it's recommended to update your app.json file prior to November 28th, 2022. Ensure that you are subscribed to Eco prior to updating your files. To help ease the migration to Eco, billing for Eco dynos doesn't start until December 1st, 2022.
Basic Dynos
Basic dynos aren't yet available. If you use Hobby dynos in your app.json files, don't update them to Basic until after November 28th, 2022. Even if you don't update your file after this date, any app.json files that use hobby dynos will provision basic dynos instead for the foreseeable future. As this plan is just a name change, billing commences immediately.
Mini Data Plans
If you want to switch from using hobby-dev to mini data plans, it's recommended to update your app.json file prior to November 28th, 2022. To help ease the migration from hobby-dev to the new plan, billing for Mini plans doesn't start until December 1st, 2022.
Basic Postgres Plans
If you want to switch from using hobby-basic to basic Heroku Postgres plans, it's recommended to update your app.json file prior to November 28th, 2022. As this plan is just a name change, billing commences immediately.
See our blog post and the Low-Cost Plans FAQ for more info related to our new plans.

https://help.heroku.com/8Q7RIYBC/when-should-i-update-my-app-json-file-to-use-the-new-dyno-and-data-plans

@vishnu-narayanan vishnu-narayanan marked this pull request as ready for review November 30, 2022 10:25
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: draft The pull request is not ready to be reviewed labels Nov 30, 2022
@vishnu-narayanan
Copy link
Member Author

image

@vishnu-narayanan vishnu-narayanan merged commit c3b6e1a into develop Dec 5, 2022
@vishnu-narayanan vishnu-narayanan deleted the fix/heroku_deployment branch December 5, 2022 15:45
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: unreviewed This pull request is yet to be reviewed. labels Dec 5, 2022
clairton pushed a commit to clairton/chatwoot that referenced this pull request Dec 20, 2022
* fix: update heroku app.json to use premium plans

Use premium/paid dynos and addons as Heroku is set to deprecate free dynos/addons.

* fix: set default stack to heroku-20

* chore: update heroku app.json to use new dyno types

web and worker to use basic dynos
redis and postgres to use mini
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-hold Issue is currently on hold post-planning The issues which are taken into the sprint after the planning session PR: merged The pull request is merged to another branch ready-for-pickup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatwook 1-Click Heroku fails deployment
2 participants