Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heorku deploy failure #5338

Merged
merged 3 commits into from
Aug 30, 2022
Merged

fix: heorku deploy failure #5338

merged 3 commits into from
Aug 30, 2022

Conversation

vishnu-narayanan
Copy link
Member

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #5284

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Aug 25, 2022
@vishnu-narayanan
Copy link
Member Author

image

@vishnu-narayanan
Copy link
Member Author

Successful after setting the default stack to Heroku-20.

image

@@ -395,7 +395,7 @@
t.datetime "agent_last_seen_at"
t.jsonb "additional_attributes", default: {}
t.bigint "contact_inbox_id"
t.uuid "uuid", default: -> { "public.gen_random_uuid()" }, null: false
t.uuid "uuid", default: -> { "gen_random_uuid()" }, null: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change necessary or will it work with stack alone ?

@pr-triage pr-triage bot added PR: reviewed-approved All reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Aug 30, 2022
@fayazara fayazara merged commit d7cbeed into develop Aug 30, 2022
@fayazara fayazara deleted the fix/heroku-deploy-failure branch August 30, 2022 06:09
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: reviewed-approved All reviewers have approved the PR labels Aug 30, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatwook 1-Click Heroku fails deployment
3 participants