-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Revamps editor for message and article #6145
Conversation
✅ Deploy Preview for chatwoot-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Cases tested on Message EditorMenu
Keyboard Shortcuts
Existing behavior
|
@nithindavid Nice work here! This is a real improvement in the editor. The help center editor feels awesome. Some minor suggestions.
|
@pranavrajs Is spacing issue between the menu and title or the typography? |
@pranavrajs Thanks for the feedback :) I have fixed the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nithindavid Tested this PR locally, and it's working as expected. Found an issue,
-
If enter to send is enabled, we cannot break the line to the new one.
https://www.loom.com/share/30eb69e31992438998586bc011b0b5d9 -
Feels not aligned properly if the first item is not active, same in help center
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks
The title area seems to be resizable, can we disable that?
Screen.Recording.2023-01-11.at.5.16.25.PM.mov
In the editor, you can see two scrollbars for some reason, can we fix that?
Screen.Recording.2023-01-11.at.5.20.13.PM.mov
@scmmishra @iamsivin Thanks for the review. I'll fix them soon.
|
@scmmishra This was done with initial feedback on the old editor to match the typography on the article view page. eg: https://chatwoot.help/hc/handbook/en/engineering/15. The font size is 18px here. Please let me know what you think. cc: @pranavrajs |
@scmmishra @nithindavid Let us try to match the experience end user is getting so that it doesn't like an entirely different content when the user publishes it. |
@iamsivin @scmmishra I have made the fixes. Can you let me know if this is good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR locally and it's working as expected 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR introduces separate editors for the message reply box and article editor in the help center. With support for keyboard rules to trigger formatting marks like bold, italics, code, lists etc.
Will update list of new changes introduced as a doc, meanwhile please see the comment on test cases.
Introduces new icons on the menu
Improves UI for canned response selector
Loom video for message editor: https://www.loom.com/share/10f36094f4b14bf0b48d8c6f9ca17a3d
Loom video for article editor: https://www.loom.com/share/6dea1e175a384bc39e1e69b9e0a92645
Notes while testing
yarn install --force
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: