feat: add activity message for priority change #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scmmishra
commented
Apr 19, 2023
scmmishra
commented
✅ Deploy Preview for chatwoot-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
scmmishra
commented
Apr 19, 2023
Comment on lines
72
to
73
| typing_status_manager = ::Conversations::FilterService.new(@conversation, current_user, params) | ||
| typing_status_manager.toggle_typing_status |
There was a problem hiding this comment.
@sojan-official this change is to manage the rubocop error of too many lines, is it unecessary?
pranavrajs
reviewed
Apr 19, 2023
Screen.Recording.2023-04-20.at.12.20.03.PM.mov
|
|
@muhsin-k noted, fixing that |
muhsin-k
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
It is working well.
https://www.loom.com/share/d4e9939a30f448348e265e6f6d741731
pr-triage
bot
removed
the
PR: unreviewed
pr-triage
bot
added
the
PR: partially-approved
tejaswinichile
approved these changes
Apr 20, 2023
pr-triage
bot
added
PR: merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.