Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Feature flags on account (#814) #815

Merged
merged 4 commits into from
May 4, 2020

Conversation

sony-mathew
Copy link
Contributor

@sony-mathew sony-mathew commented May 4, 2020

Fixes #814

Description

  • Added the new column on account model for managing feature flags
  • Encapsulated the feature flagging as a concern. With this, we can re-use the same concern if we introduce this in other models like user or inbox or so.
  • Added the inbound email flag
  • Locked the fields of this feature in account settings based on this
  • Added the features in the account API responses

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Self-testing has been performed. [Self-attestation stamp]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

* Added the new column on account model for managing feature flags
* Added the inbound email flag
* Locked the settings of this eature in account settings based on this
* Encapsulated the feature flaging as a concern. With this, we can re-use the same concern if we introduce this in other models like user or inbox or so.
* Added the features in the account api
@sony-mathew sony-mathew added this to the v1.4.0 milestone May 4, 2020
@sony-mathew sony-mathew self-assigned this May 4, 2020
@sony-mathew sony-mathew added the feature-request This label is used to track new features which is a significant change to existing product label May 4, 2020
@sony-mathew sony-mathew merged commit fabc317 into develop May 4, 2020
@sony-mathew sony-mathew deleted the feature/814-feature-flags branch May 4, 2020 17:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request This label is used to track new features which is a significant change to existing product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Feature flags on accounts
2 participants