Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting dashboard scripts from super_admin #9514

Merged
merged 7 commits into from
May 23, 2024

Conversation

scmmishra
Copy link
Member

@scmmishra scmmishra commented May 21, 2024

This PR allows setting scripts for vueapp.html.erb via super admin config. This PR has the following changes

  1. Allow DASHBOARD_SCRIPTS in internal config
  2. Remove existing scripts from vueapp.html.erb
  3. Add scripts from GlobalConfig to vueapp.html.erb

Copy link

linear bot commented May 21, 2024

@scmmishra scmmishra requested review from sojan-official and pranavrajs and removed request for sojan-official May 21, 2024 17:18
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9514 May 23, 2024 08:03 Inactive
@scmmishra scmmishra merged commit 616e3a8 into develop May 23, 2024
15 checks passed
@scmmishra scmmishra deleted the feature/cw-3330 branch May 23, 2024 09:00
clairton pushed a commit to clairton/chatwoot that referenced this pull request Jun 13, 2024
This PR allows setting scripts for `vueapp.html.erb` via super admin
config. This PR has the following changes

1. Allow `DASHBOARD_SCRIPTS` in internal config
2. Remove existing scripts from `vueapp.html.erb`
3. Add scripts from `GlobalConfig` to `vueapp.html.erb`

---------

Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants