Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Google login flow and inbox creation #9580

Merged
merged 44 commits into from
Jun 7, 2024
Merged

Conversation

scmmishra
Copy link
Member

@scmmishra scmmishra commented Jun 3, 2024

This PR adds the following changes

  1. Refactor microsoft/callbacks_controller to move common logic to oauth_callback_controller, most of the logic is re-used for Google
  2. Add UI components, googleClient and I18n entries for Google login
  3. Add Google callback and inbox creation
  4. Add a joinUrl utility along with specs (need to move it to utils)
  5. Add GoogleConcern, Google::AuthorizationsController and Google::CallbacksController

Note: The UI is hidden for now, so we can merge this without any hiccups, to enable it just revert the commit 05c18de

Preview

CleanShot.2024-06-03.at.12.22.48.mp4

Linear Tickers

CW-3370
CW-3371

@chatwoot chatwoot deleted a comment from linear bot Jun 3, 2024
Copy link

linear bot commented Jun 5, 2024

@scmmishra
Copy link
Member Author

@muhsin-k can you review and test this? Revert the 05c18de commit and it will enable the Google flow

@muhsin-k muhsin-k self-requested a review June 6, 2024 05:21
@scmmishra scmmishra temporarily deployed to chatwoot-pr-9580 June 6, 2024 10:54 Inactive
@scmmishra
Copy link
Member Author

@pranavrajs do you wanna take a peek at the code? This is tested on staging

@scmmishra scmmishra merged commit da4b75a into develop Jun 7, 2024
16 checks passed
@scmmishra scmmishra deleted the feature/cw-3369 branch June 7, 2024 11:07
Copy link

github-actions bot commented Jul 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants